Merged
Conversation
elit0451
suggested changes
Apr 8, 2024
Contributor
elit0451
left a comment
There was a problem hiding this comment.
Looks great 🙌
We already went over my review suggestions, but for documentation purposes here are the things I'll push:
- Added
CancellationTokento the new endpoints; - Fixed authz policies of the new controllers;
- Refactored
ContentBlueprintEditingService.MoveAsync()to use theContentBlueprintEditingServicemethods instead of underlyingContentService.
I'd just ask you to use Assert.Multiple where it makes sense in ContentBlueprintContainerServiceTests
elit0451
approved these changes
Apr 8, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR introduces blueprint containers (folders) for explicitly organizing blueprints in a tree, rather than the current virtual (fake) structure by content type.
As part of the migration to V14, all existing blueprints will be moved into containers named by their content type, thus mimicking the structure that is today.
Testing this PR
Create a V13 site with blueprints (or reach out to @kjac for a test DB):
Upgrade the V13 database to V14, then use the API to verify that the blueprints have been moved into containers:
Now test that:
Limitations of this PR
This PR does not support creating blueprints from existing content in a container. We need to work out the client-side details of this feature before we implement the APIs to support it.